etcd: add basic support #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigbes
force-pushed
the
bigbes/tntp-4189-etcd-driver
branch
from
1ecc345 to
562c5bc
Compare
Pull Request Test Coverage Report for Build 19138272403Details
💛 - Coveralls |
bigbes
force-pushed
the
bigbes/tntp-4189-etcd-driver
branch
from
562c5bc to
61c9309
Compare
* implemented etcd driver (backend) for basic storage * used etcd `testing.LazyCluster` for integration testing * modified .golangci.yaml to add new library exclusion Part of #TNTP-4189
bigbes
force-pushed
the
bigbes/tntp-4189-etcd-driver
branch
from
61c9309 to
7c76d2e
Compare
patapenka-alexey
approved these changes
Nov 11, 2025
elhimov
reviewed
Nov 14, 2025
| return tx.Response{}, fmt.Errorf("failed to convert then operations: %w", err) | ||
| } | ||
|
|
||
| txn = txn.Then(thenEtcdOps...) |
Contributor
There was a problem hiding this comment.
It looks like the only purpose of returned Txn in If/Then/Else is to be able to write one-liner txn.If().Then().Else().Commit(), so it seems this assignment is useless
Suggested change
| txn = txn.Then(thenEtcdOps...) | |
| txn.Then(thenEtcdOps...) |
| return tx.Response{}, fmt.Errorf("failed to convert else operations: %w", err) | ||
| } | ||
|
|
||
| txn = txn.Else(elseEtcdOps...) |
| func TestPredicateToCmp(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| tests := []struct { |
Contributor
There was a problem hiding this comment.
Nit: I'd suggest to use map[string]struct for tests table instead of slice as it has some advantages w/o additional complexity (https://go.dev/wiki/TableDrivenTests#using-a-map-to-store-test-cases).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing.LazyClusterfor integration testingPart of #TNTP-4189